Allow removal of gzip_types from the config #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change to server behaviour. Fixes #748
|
Thanks for this patch! I have applied this patched locally to get rid of the warning and I would highly appreciate if this would be merged and released as part of the next puppet-nginx version. |
3flex
added a commit
that referenced
this pull request
Feb 15, 2016
Allow removal of gzip_types from the config
|
That was quick, thank you! |
Slm0n87
pushed a commit
to Slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
Allow removal of gzip_types from the config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default value is not ideal, as 'text/html' is always included whether specified in the config or not. If it's specified, nginx shows a warning on start up.
Fixes #748